Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔨 implement "IN" and "NOT IN" in text custom fields #128

Open
wants to merge 1 commit into
base: MOODLE_404_STABLE
Choose a base branch
from

Conversation

szvarhegyi
Copy link

Hello everyone,

I am the developer of the SmartCohort plugin from CNW Co., a Moodle Partner. We have transitioned to Dynamic Cohort in our cloud service, and our goal is to assist you with our developments in the future.

One of our clients reported that they are unable to create a specific rule that was possible in SmartCohort. To enable this functionality, I have implemented the "IN" and "NOT IN" conditions. Currently, it simply separates the values with commas and applies the filtering accordingly.

Is there anything else we need to do to get this officially included?

You can add this condition:
image

Or this:
image

image

@dmitriim
Copy link
Member

thanks @szvarhegyi !
Before we can proceed with the review, can you please create an issue and describe the problem you are trying to solve by this enhancement. That would help us understand your intentions and well as would let others potentially struggling with the same problem to find that it's being solved.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants